Skip to content

Do not output (null) for missing icons #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 12, 2025
Merged

Do not output (null) for missing icons #27

merged 1 commit into from
Feb 12, 2025

Conversation

johanmalm
Copy link
Collaborator

@Consolatis - welcome review

@Consolatis
Copy link
Member

Consolatis commented Feb 12, 2025 •
edited
Loading

LGTM.

Technically we could also not add the icon= in the first place if the value is invalid anyway. But an empty string early returns in the labwc logic before requesting the icon name from libsfdo so its an improvement. Both variants are fine by me.

Edit:
Looking at it again it seems it just needs a if (show_icons && app->icon) { for the two conditions.

@johanmalm
Handle missing Icon= in .desktop file better
53f47a4 
...by omitting the icon attribute rather than outputting icon="(null)"

Helped-by: @Consolatis
@johanmalm johanmalm merged commit a6e96b4 into master Feb 12, 2025
3 checks passed
@johanmalm johanmalm deleted the no-null-icons branch February 12, 2025 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johanmalm @Consolatis